Groups > linux.kernel > #1220185

Re: [PATCH] btrfs: memset cur_trans->delayed_refs to zero

Path	csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!us.feeder.erje.net!news2.arglkargh.de!news.albasani.net!tahina.priv.at!bofh.it!news.nic.it!robomod
From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] btrfs: memset cur_trans->delayed_refs to zero
Date	Mon, 07 Sep 2015 16:10:01 +0200
Message-ID	<q65hn-7Mu-1@gated-at.bofh.it> (permalink)
References	<q64Y1-7am-7@gated-at.bofh.it>
X-Original-To	Alexandru Moise <00moses.alexander00@gmail.com>
Reply-To	dsterba@suse.cz
Mail-Followup-To	dsterba@suse.cz, Alexandru Moise <00moses.alexander00@gmail.com>, clm@fb.com, jbacik@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23.1-rc1 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	clm@fb.com, jbacik@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 7 Sep 2015 16:01:22 +0200
X-Original-Message-ID	<20150907140122.GX11834@suse.cz>
X-Original-References	<20150907134502.GA19553@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1220185

Show key headers only | View raw

So, updated patches should mention that in the subject eg:

[PATCH v2] btrfs: memset cur_trans->delayed_refs to zero

On Mon, Sep 07, 2015 at 04:45:02PM +0300, Alexandru Moise wrote:
> Use memset() to null out the btrfs_delayed_ref_root of
> btrfs_transaction instead of setting all the members to 0 by hand.
> 
> Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
> ---

And in this section (ie. after the first ---) put a brief description of
the changes.

>  fs/btrfs/transaction.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index 8f259b3..0581fb4 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -224,15 +224,15 @@ loop:
>  	cur_trans->start_time = get_seconds();
>  	cur_trans->dirty_bg_run = 0;
>  
> +	memset(&cur_trans->delayed_refs, 0, sizeof(cur_trans->delayed_refs));
> +
> +	/*
> +	 * For now RB_ROOT means set to NULL but this could change in
> +	 * the future
> +	 */

I don't think such comment necessary, the code is clear enough without
it.

>  	cur_trans->delayed_refs.href_root = RB_ROOT;
>  	cur_trans->delayed_refs.dirty_extent_root = RB_ROOT;

.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] btrfs: memset cur_trans->delayed_refs to zero Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-07 15:50 +0200
  Re: [PATCH] btrfs: memset cur_trans->delayed_refs to zero David Sterba <dsterba@suse.cz> - 2015-09-07 16:10 +0200
    Re: [PATCH] btrfs: memset cur_trans->delayed_refs to zero Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-07 16:30 +0200

csiph-web