Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220072
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl() |
| Date | 2015-09-07 13:30 +0200 |
| Message-ID | <q62My-47x-25@gated-at.bofh.it> (permalink) |
| References | <pZMAO-1LC-5@gated-at.bofh.it> <pZMAO-1LC-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 21/08/2015 06:50, Xiao Guangrong wrote:
>
> +static void set_clear_2nd_exec_ctrl(u32 ctrls, bool set)
> +{
> + u32 exec_ctrl = vmcs_read32(SECONDARY_VM_EXEC_CONTROL);
> +
> + if (set)
> + exec_ctrl |= ctrls;
> + else
> + exec_ctrl &= ~ctrls;
> +
> + vmcs_write32(SECONDARY_VM_EXEC_CONTROL, exec_ctrl);
> +}
The second argument is always true. Do you have any plans for it?
Should we instead add functions like vmcs_or32 and vmcs_clear32?
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/9] KVM: x86: enable cflushopt/clwb/pcommit and simplify code Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
[PATCH 9/9] KVM: VMX: drop rdtscp_enabled field Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
[PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl() Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl() Paolo Bonzini <pbonzini@redhat.com> - 2015-09-07 13:30 +0200
Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl() Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-09-08 16:40 +0200
Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl() Paolo Bonzini <pbonzini@redhat.com> - 2015-09-08 22:40 +0200
[PATCH 3/9] KVM: x86: add pcommit support Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
Re: [PATCH 3/9] KVM: x86: add pcommit support Paolo Bonzini <pbonzini@redhat.com> - 2015-09-07 13:20 +0200
Re: [PATCH 3/9] KVM: x86: add pcommit support Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-09-08 16:30 +0200
Re: [PATCH 3/9] KVM: x86: add pcommit support Paolo Bonzini <pbonzini@redhat.com> - 2015-09-08 22:40 +0200
[PATCH 1/9] KVM: MMU: fix use uninitialized value Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
[PATCH 7/9] KVM: VMX: unify SECONDARY_VM_EXEC_CONTROL update Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
[PATCH 4/9] KVM: VMX: drop rdtscp_enabled check in prepare_vmcs02() Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
[PATCH 5/9] KVM: VMX: simplify rdtscp handling in vmx_cpuid_update() Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-08-21 07:00 +0200
csiph-web