Groups > linux.kernel > #1220065

Re: [PATCH V4 2/2] arm64: Change memcpy in kernel to use the copy template file

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 2/2] arm64: Change memcpy in kernel to use the copy template file
Date	Mon, 07 Sep 2015 13:20:02 +0200
Message-ID	<q62CS-3We-17@gated-at.bofh.it> (permalink)
References	<q02FA-8ev-9@gated-at.bofh.it> <q02FA-8ev-23@gated-at.bofh.it>
X-Original-To	Feng Kan <fkan@apm.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	patches@apm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, philipp.tomsich@theobroma-systems.com, dann.frazier@canonical.com, tim.gardner@canonical.com, craig.magina@canonical.com, soni.trilok.oss@gmail.com
X-Original-Date	Mon, 7 Sep 2015 12:13:52 +0100
X-Original-Message-ID	<20150907111351.GB10645@e104818-lin.cambridge.arm.com>
X-Original-References	<1440194458-4837-1-git-send-email-fkan@apm.com> <1440194501-4953-1-git-send-email-fkan@apm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1220065

Show key headers only | View raw

On Fri, Aug 21, 2015 at 03:01:41PM -0700, Feng Kan wrote:
> This converts the memcpy.S to use the copy template file. The copy
> template file was based originally on the memcpy.S. Minor changes
> was made to it to accommodate the copy to/from/in user files.

I think it will be easier to follow if you make this patch the first,
just a simple move of code without any functional change.

> 
> Signed-off-by: Feng Kan <fkan@apm.com>
> ---
>  arch/arm64/lib/memcpy.S | 179 +++++++-----------------------------------------
>  1 file changed, 26 insertions(+), 153 deletions(-)
> 
> diff --git a/arch/arm64/lib/memcpy.S b/arch/arm64/lib/memcpy.S
> index 8a9a96d..761acd7 100644
> --- a/arch/arm64/lib/memcpy.S
> +++ b/arch/arm64/lib/memcpy.S
[...]
> +        .macro strh1 label, ptr, regB, val
> +        strh \ptr, [\regB], \val
> +        .endm

There is a problem with the tab/space conversion, either in your editor
or the email server. The above indentation should use tabs (and the
subsequent ones).

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V4 2/2] arm64: Change memcpy in kernel to use the copy template file Feng Kan <fkan@apm.com> - 2015-08-22 00:10 +0200
  Re: [PATCH V4 2/2] arm64: Change memcpy in kernel to use the copy  template file Catalin Marinas <catalin.marinas@arm.com> - 2015-09-07 13:20 +0200

csiph-web