Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220048
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Luis Henriques <luis.henriques@canonical.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] zram: fix possible use after free in zcomp_create() |
| Date | Mon, 07 Sep 2015 12:40:02 +0200 |
| Message-ID | <q620a-2XP-21@gated-at.bofh.it> (permalink) |
| X-Original-To | Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org> |
| X-Mailer | git-send-email 2.1.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 36 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 7 Sep 2015 11:33:53 +0100 |
| X-Original-Message-ID | <1441622033-8358-1-git-send-email-luis.henriques@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1220048 |
Show key headers only | View raw
zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create()
through comp->stream, which can potentially be pointing to memory that was
freed if these functions returned an error.
Fixes: beca3ec71fe5 ("zram: add multi stream functionality")
Cc: stable@vger.kernel.org
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
drivers/block/zram/zcomp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
index 965d1afb0eaa..f3db8158e172 100644
--- a/drivers/block/zram/zcomp.c
+++ b/drivers/block/zram/zcomp.c
@@ -212,6 +212,7 @@ static int zcomp_strm_multi_create(struct zcomp *comp, int max_strm)
zstrm = zcomp_strm_alloc(comp);
if (!zstrm) {
kfree(zs);
+ comp->stream = NULL;
return -ENOMEM;
}
list_add(&zstrm->list, &zs->idle_strm);
@@ -262,6 +263,7 @@ static int zcomp_strm_single_create(struct zcomp *comp)
zs->zstrm = zcomp_strm_alloc(comp);
if (!zs->zstrm) {
kfree(zs);
+ comp->stream = NULL;
return -ENOMEM;
}
return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] zram: fix possible use after free in zcomp_create() Luis Henriques <luis.henriques@canonical.com> - 2015-09-07 12:40 +0200
Re: [PATCH] zram: fix possible use after free in zcomp_create() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-07 13:20 +0200
Re: [PATCH] zram: fix possible use after free in zcomp_create() Luis Henriques <luis.henriques@canonical.com> - 2015-09-07 15:00 +0200
Re: [PATCH] zram: fix possible use after free in zcomp_create() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-07 15:40 +0200
Re: [PATCH] zram: fix possible use after free in zcomp_create() Luis Henriques <luis.henriques@canonical.com> - 2015-09-07 16:20 +0200
[PATCH v2] zram: fix possible use after free in zcomp_create() Luis Henriques <luis.henriques@canonical.com> - 2015-09-07 16:20 +0200
Re: [PATCH v2] zram: fix possible use after free in zcomp_create() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-08 02:00 +0200
Re: [PATCH v2] zram: fix possible use after free in zcomp_create() Minchan Kim <minchan@kernel.org> - 2015-09-08 03:10 +0200
Re: [PATCH v2] zram: fix possible use after free in zcomp_create() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-08 03:30 +0200
Re: [PATCH v2] zram: fix possible use after free in zcomp_create() Minchan Kim <minchan@kernel.org> - 2015-09-08 03:40 +0200
[PATCH v3] zram: fix possible use after free in zcomp_create() Luis Henriques <luis.henriques@canonical.com> - 2015-09-08 11:40 +0200
Re: [PATCH v3] zram: fix possible use after free in zcomp_create() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-08 12:00 +0200
Re: [PATCH v3] zram: fix possible use after free in zcomp_create() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-08 12:30 +0200
Re: [PATCH v3] zram: fix possible use after free in zcomp_create() Minchan Kim <minchan@kernel.org> - 2015-09-08 15:40 +0200
csiph-web