Groups > linux.kernel > #1220046

Re: [PATCH V3 1/3] kvm: use kmalloc() instead of kzalloc() during iodev register/unregister

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 1/3] kvm: use kmalloc() instead of kzalloc() during iodev register/unregister
Date	Mon, 07 Sep 2015 12:40:02 +0200
Message-ID	<q620a-2XP-11@gated-at.bofh.it> (permalink)
References	<q1iyB-2ao-15@gated-at.bofh.it>
X-Original-To	Jason Wang <jasowang@redhat.com>, gleb@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.24
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	cornelia.huck@de.ibm.com, "Michael S. Tsirkin" <mst@redhat.com>
X-Original-Date	Mon, 7 Sep 2015 12:33:51 +0200
X-Original-Message-ID	<55ED680F.4080100@redhat.com>
X-Original-References	<1440493548-2971-1-git-send-email-jasowang@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1220046

Show key headers only | View raw


On 25/08/2015 11:05, Jason Wang wrote:
> All fields of kvm_io_range were initialized or copied explicitly
> afterwards. So switch to use kmalloc().
> 
> Cc: Gleb Natapov <gleb@kernel.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  virt/kvm/kvm_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 8b8a444..0d79fe8 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -3248,7 +3248,7 @@ int kvm_io_bus_register_dev(struct kvm *kvm, enum kvm_bus bus_idx, gpa_t addr,
>  	if (bus->dev_count - bus->ioeventfd_count > NR_IOBUS_DEVS - 1)
>  		return -ENOSPC;
>  
> -	new_bus = kzalloc(sizeof(*bus) + ((bus->dev_count + 1) *
> +	new_bus = kmalloc(sizeof(*bus) + ((bus->dev_count + 1) *
>  			  sizeof(struct kvm_io_range)), GFP_KERNEL);
>  	if (!new_bus)
>  		return -ENOMEM;
> @@ -3280,7 +3280,7 @@ int kvm_io_bus_unregister_dev(struct kvm *kvm, enum kvm_bus bus_idx,
>  	if (r)
>  		return r;
>  
> -	new_bus = kzalloc(sizeof(*bus) + ((bus->dev_count - 1) *
> +	new_bus = kmalloc(sizeof(*bus) + ((bus->dev_count - 1) *
>  			  sizeof(struct kvm_io_range)), GFP_KERNEL);
>  	if (!new_bus)
>  		return -ENOMEM;
> 

Applied this patch for 4.4.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3 1/3] kvm: use kmalloc() instead of kzalloc() during iodev register/unregister Jason Wang <jasowang@redhat.com> - 2015-08-25 11:20 +0200
  [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses Jason Wang <jasowang@redhat.com> - 2015-08-25 11:20 +0200
    Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses Cornelia Huck <cornelia.huck@de.ibm.com> - 2015-08-25 13:00 +0200
    Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-25 13:40 +0200
    Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-25 14:00 +0200
      Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses Jason Wang <jasowang@redhat.com> - 2015-08-26 07:20 +0200
        Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses Jason Wang <jasowang@redhat.com> - 2015-08-31 05:20 +0200
          Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-31 09:30 +0200
            Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses Jason Wang <jasowang@redhat.com> - 2015-08-31 10:10 +0200
              Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-31 13:40 +0200
                Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses Jason Wang <jasowang@redhat.com> - 2015-09-01 05:40 +0200
                Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-01 06:40 +0200
                Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses Jason Wang <jasowang@redhat.com> - 2015-09-01 06:50 +0200
                Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-01 09:00 +0200
                Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses Jason Wang <jasowang@redhat.com> - 2015-09-01 10:30 +0200
                Re: [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two  buses "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-01 10:40 +0200
  [PATCH V3 3/3] kvm: add tracepoint for fast mmio Jason Wang <jasowang@redhat.com> - 2015-08-25 11:20 +0200
    Re: [PATCH V3 3/3] kvm: add tracepoint for fast mmio "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-25 13:40 +0200
  Re: [PATCH V3 1/3] kvm: use kmalloc() instead of kzalloc() during  iodev register/unregister Paolo Bonzini <pbonzini@redhat.com> - 2015-09-07 12:40 +0200

csiph-web