Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1220009

Re: [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA

From Christian Gromm <christian.gromm@microchip.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA
Date 2015-09-07 11:10 +0200
Message-ID <q60B4-15o-9@gated-at.bofh.it> (permalink)
References <q402u-8on-11@gated-at.bofh.it>
Organization MCHP

Show all headers | View raw


On Tue, 1 Sep 2015 22:05:58 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> If NO_DMA=y:
> 
>     ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
>     ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
> 
> As all MOST sub drivers use DMA functionality, add a dependency on
> HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
>  drivers/staging/most/Kconfig          | 1 +
>  drivers/staging/most/mostcore/Kconfig | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/most/Kconfig b/drivers/staging/most/Kconfig
> index d50de03de7b98972..0b9b9b539f70562d 100644
> --- a/drivers/staging/most/Kconfig
> +++ b/drivers/staging/most/Kconfig
> @@ -1,5 +1,6 @@
>  menuconfig MOST
>          tristate "MOST driver"
> +	depends on HAS_DMA
>          select MOSTCORE
>          default n
>          ---help---
> diff --git a/drivers/staging/most/mostcore/Kconfig b/drivers/staging/most/mostcore/Kconfig
> index 38abf1b21b6623c7..47172546d7280ee6 100644
> --- a/drivers/staging/most/mostcore/Kconfig
> +++ b/drivers/staging/most/mostcore/Kconfig
> @@ -4,6 +4,7 @@
>  
>  config MOSTCORE
>  	tristate "MOST Core"
> +	depends on HAS_DMA
>  
>  	---help---
>  	  Say Y here if you want to enable MOST support.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-01 22:10 +0200
  Re: [PATCH] Staging: most: MOST and MOSTCORE should depend on  HAS_DMA Christian Gromm <christian.gromm@microchip.com> - 2015-09-07 11:10 +0200

csiph-web