Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219551

Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation

Show all headers | View raw

Russell,

On Sat, Sep 5, 2015 at 1:31 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Sep 04, 2015 at 07:03:11PM -0700, Doug Anderson wrote:
>> AKA: just replace your entire "compute_n" function with:
>>
>> return (128 * freq) / 1000;
>>
>> ...and it's 100% simpler _and_ gets you a (marginally) better rate
>> (assuming you really have 22.175000).  If it was just about a
>> 32000.222 vs 32000 I'd not be saying anything right now.  It's about
>> adding complexity.
>
> No.  It doesn't work for all cases.  Do the calculations for every
> sample rate in those tables in the HDMI spec, and you'll find out
> why.

If you know the answer, just tell me.  If you're talking about 74.25
vs. 32 kHz it is further evidence of what I'm saying.  Note that
picking only one of the two listed CTS values again puts you in a
worse position for regenerating the proper audio clock then just using
the default N=4096.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation Doug Anderson <dianders@chromium.org> - 2015-09-04 20:30 +0200
  Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation Doug Anderson <dianders@chromium.org> - 2015-09-04 21:50 +0200
    Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N  calculation Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-04 23:30 +0200
      Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation Doug Anderson <dianders@chromium.org> - 2015-09-05 02:00 +0200
        Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N  calculation Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-05 02:30 +0200
          Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation Doug Anderson <dianders@chromium.org> - 2015-09-05 04:10 +0200
            Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N  calculation Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-05 10:40 +0200
              Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation Doug Anderson <dianders@chromium.org> - 2015-09-05 16:00 +0200
            Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N  calculation Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-05 10:40 +0200
              Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation Doug Anderson <dianders@chromium.org> - 2015-09-05 15:50 +0200
                Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N  calculation Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-05 16:10 +0200
                Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation Doug Anderson <dianders@chromium.org> - 2015-09-05 21:50 +0200

csiph-web