Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219513

Re: [PATCH v2 1/2] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 2015-08-05 at 15:01 +0400, Ivan Mikhaylov wrote:
> * do the redefinition of emac_regs struct from driver structure perspective
>   and passing size from actual struct size, not from memory area variable
>   which set in dts file.
> 
> * passing variable from dts option may cause a problem with output below 
>   MII's section which we're fixing with this and 5369c71 commit in kernel.
[...]

But you still aren't handling the case where only one of the driver and
ethtool is upgraded, even by reporting an error.

I'm never going to apply patches to ethtool that obviously break binary
compatibility, so you are wasting your time sending me new versions
that do that.

At this point you should probably just bump the dump version numbers in
both places.

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/2] ethtool: changes of emac_regs structure  accordingly within driver emac_regs structure. Ben Hutchings <ben@decadent.org.uk> - 2015-09-05 12:50 +0200

csiph-web