Groups > linux.kernel > #1219439

Re: [PATCH] x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h
Date	2015-09-05 09:40 +0200
Message-ID	<q5geR-2go-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <q4m30-68s-9@gated-at.bofh.it> <q4xrs-5yf-11@gated-at.bofh.it> <q4TrY-3vn-15@gated-at.bofh.it> <q4V0L-5zg-33@gated-at.bofh.it> <q4Y8j-1MD-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Mikko Rapeli <mikko.rapeli@iki.fi> wrote:

> > sigcontext32.h is a 64-bit only header (for compat functionality), and you are 
> > trying to build this on i386, right?
> 
> Yes, i386 32bit.
> 
> > In theory we could unify them mostly, the two structures match mostly, except that 
> > '_fpstate_ia32::padding' is named 'padding1' in _fpstate, and there's also some 
> > legacy uglies wrt. user-space sigcontext definitions.
> > 
> > So this either gets cleaned up properly, with the legacy hacks/wrappers clearly 
> > isolated, or we could state that you shouldn't build 64-bit headers in 32-bit 
> > environments.
> 
> Should the sigcontext32.h have some 32bit ifdefs maybe?

That gets ugly pretty fast.

> I assume that the exported header files should be the same for both 64 and 32
> bit i386/x86

Yes. I have written a small series cleaning up all these header problems - I'll 
send it out in a few minutes.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 94/98] HACK arch/x86/include/uapi/asm/sigcontext32.h:  remove _fpx_sw_bytes from union Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-02 21:40 +0200
  [PATCH] x86/headers: Fix (old) header file dependency bug in  uapi/asm/sigcontext32.h Ingo Molnar <mingo@kernel.org> - 2015-09-03 09:50 +0200
    Re: [PATCH] x86/headers: Fix (old) header file dependency bug in  uapi/asm/sigcontext32.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-04 09:20 +0200
      Re: [PATCH] x86/headers: Fix (old) header file dependency bug in  uapi/asm/sigcontext32.h Ingo Molnar <mingo@kernel.org> - 2015-09-04 11:00 +0200
        Re: [PATCH] x86/headers: Fix (old) header file dependency bug in  uapi/asm/sigcontext32.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-04 14:20 +0200
          Re: [PATCH] x86/headers: Fix (old) header file dependency bug in  uapi/asm/sigcontext32.h Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200

csiph-web