Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219456

Re: [PATCH] staging: slicoss: remove unused variables

Show all headers | View raw

On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote:
> On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > These variables were only assigned some values but they were never used.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
<snip>
> > -       status = slic_upr_request(adapter, SLIC_UPR_RLSR,
> > -               (u32) &pshmem->linkstatus,      /* no 4GB wrap guaranteed */
> > -                                 0, 0, 0);
> > +       slic_upr_request(adapter, SLIC_UPR_RLSR,
> > +                        (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */
> > +                        0, 0, 0);
> 
> Is status safe to ignore?
status can have two value either -ENOMEM or STATUS_PEMDING.
Ideally we should have handled -ENOMEM.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: slicoss: remove unused variables Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-04 15:30 +0200
  Re: [PATCH] staging: slicoss: remove unused variables David Matlack <dmatlack@google.com> - 2015-09-04 20:20 +0200
    Re: [PATCH] staging: slicoss: remove unused variables Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-05 10:10 +0200

csiph-web