Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1219978
| From | Mikko Rapeli <mikko.rapeli@iki.fi> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> |
| Date | 2015-09-07 10:20 +0200 |
| Message-ID | <q5ZOF-8nj-7@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <q5ksa-8rE-15@gated-at.bofh.it> <q5kBQ-bb-11@gated-at.bofh.it> <q5BW1-7SJ-1@gated-at.bofh.it> <q5OJz-Ua-5@gated-at.bofh.it> <q5ZbY-7oS-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Sep 07, 2015 at 09:37:50AM +0200, Ingo Molnar wrote: > > * Mikko Rapeli <mikko.rapeli@iki.fi> wrote: > > > > > +++ b/arch/x86/include/uapi/asm/sigcontext32.h > > > > @@ -3,6 +3,6 @@ > > > > > > > > /* This is a legacy file - all the type definitions are in sigcontext.h: */ > > > > > > > > -#include <uapi/asm/sigcontext.h> > > > > +#include <asm/sigcontext.h> > > > > > > There's no asm/sigcontext.h file anymore if you apply my patches - but we could > > > reintroduce it to make the copy of UAPI headers to user-space work as-is. > > > > Actually there is, in user space :) > > I mean in the kernel arch/x86/include/asm/sigcontext.h is gone (at least in that > series), we use the UAPI header directly. > > > Then a nice solution would be for the kernel side wrapper to do like you > > said (on top of your changes on master): > > > > --- /dev/null > > +++ b/arch/x86/include/asm/sigcontext.h > > @@ -0,0 +1,6 @@ > > +#ifndef _ASM_X86_SIGCONTEXT_H > > +#define _ASM_X86_SIGCONTEXT_H > > + > > +#include <uapi/asm/sigcontext.h> > > + > > +#endif /* _ASM_X86_SIGCONTEXT_H */ > > > > And I guess logically this belongs to commit "x86/headers: Remove > > <asm/sigcontext.h>". > > Yeah, will do this, plus some comments explaining that this is really just so that > we can keep the UAPI side compatible with a 'straight user-space copying of the > header files'. > > This won't affect the kernel as we won't include asm/sigcontext.h directly. (And > even if we do, there's no harm done.) > > Agreed? Perfect. Thanks for takling this issue! -Mikko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/15] x86/headers: Clean up sigcontext types and headers Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[PATCH 07/15] x86/headers: Unify 'struct _fpstate_ia32' and i386 struct _fpstate Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Unify 'struct _fpstate_ia32' and i386 struct _fpstate tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:40 +0200
[PATCH 08/15] x86/headers: Convert uses of _fpstate_ia32 to _fpstate_32 Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Convert uses of _fpstate_ia32 to _fpstate_32 tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
[PATCH 06/15] x86/headers: Unify register type definitions between 32-bit compat and i386 Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Unify register type definitions between 32-bit compat and i386 tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
[PATCH 12/15] x86/headers: Unify 'struct sigcontext_ia32' and 'struct sigcontext_32' Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Unify 'struct sigcontext_ia32' and 'struct sigcontext_32' tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
[PATCH 05/15] x86/headers: Use ABI types consistently in sigcontext*.h Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Use ABI types consistently in sigcontext*.h tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
[PATCH 10/15] x86/headers: Move the 'struct sigcontext' definitions into the UAPI header Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Move the 'struct sigcontext' definitions into the UAPI header tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
[PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-05 13:00 +0200
Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Ingo Molnar <mingo@kernel.org> - 2015-09-05 14:10 +0200
Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-05 14:20 +0200
Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Ingo Molnar <mingo@kernel.org> - 2015-09-06 08:50 +0200
Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-06 22:30 +0200
Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Ingo Molnar <mingo@kernel.org> - 2015-09-07 09:40 +0200
Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-07 10:20 +0200
[tip:x86/headers] x86/headers: Remove <asm/sigcontext.h> references on the kernel side tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:40 +0200
Re: [tip:x86/headers] x86/headers: Remove <asm/sigcontext.h> references on the kernel side Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-08 22:20 +0200
[PATCH 04/15] x86/headers: Separate out legacy user-space structure definitions Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Separate out legacy user-space structure definitions tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
[PATCH 01/15] x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
[PATCH 09/15] x86/headers: Clean up the kernel's struct sigcontext types to be ABI-clean Ingo Molnar <mingo@kernel.org> - 2015-09-05 09:40 +0200
[tip:x86/headers] x86/headers: Clean up the kernel' s struct sigcontext types to be ABI-clean tip-bot for Ingo Molnar <tipbot@zytor.com> - 2015-09-08 16:30 +0200
csiph-web