Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219942

Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

Show all headers | View raw

Hi Julien,

On 09/04/2015 09:51 PM, Julien Grall wrote:
> Hi Roger,
> 
> On 04/09/15 11:08, Roger Pau Monne wrote:
>> Request allocation has been moved to connect_ring, which is called every
>> time blkback connects to the frontend (this can happen multiple times during
>> a blkback instance life cycle). On the other hand, request freeing has not
>> been moved, so it's only called when destroying the backend instance. Due to
>> this mismatch, blkback can allocate the request pool multiple times, without
>> freeing it.
>>
>> In order to fix it, move the freeing of requests to xen_blkif_disconnect to
>> restore the symmetry between request allocation and freeing.
>>
>> Reported-by: Julien Grall <julien.grall@citrix.com>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Cc: Julien Grall <julien.grall@citrix.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: David Vrabel <david.vrabel@citrix.com>
>> Cc: xen-devel@lists.xenproject.org
> 
> The patch is fixing my problem when using UEFI in the guest. Thank you!
> 

Could you please explain the problem you met a bit more?
So that I can know back port this patch if met similar issue.

Thanks,
-Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen-blkback: free requests on disconnection Roger Pau Monne <roger.pau@citrix.com> - 2015-09-04 12:10 +0200
  Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Julien Grall <julien.grall@citrix.com> - 2015-09-04 16:00 +0200
    Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-09-04 19:30 +0200
    Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Bob Liu <bob.liu@oracle.com> - 2015-09-07 08:10 +0200
      Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Julien Grall <julien.grall@citrix.com> - 2015-09-07 13:30 +0200
        Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Bob Liu <bob.liu@oracle.com> - 2015-09-07 13:40 +0200
          Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Roger Pau Monné <roger.pau@citrix.com> - 2015-09-08 12:50 +0200
            Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-09-09 17:10 +0200
              Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Julien Grall <julien.grall@citrix.com> - 2015-09-22 01:20 +0200

csiph-web