Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1219940

Re: [PATCH 3/3] mm, compaction: disginguish contended status in tracepoint

From Joonsoo Kim <iamjoonsoo.kim@lge.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] mm, compaction: disginguish contended status in tracepoint
Date 2015-09-07 08:00 +0200
Message-ID <q5XDc-56n-15@gated-at.bofh.it> (permalink)
References <q27hM-8oR-17@gated-at.bofh.it> <q27hM-8oR-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 27, 2015 at 05:24:04PM +0200, Vlastimil Babka wrote:
> Compaction returns prematurely with COMPACT_PARTIAL when contended or has fatal
> signal pending. This is ok for the callers, but might be misleading in the
> traces, as the usual reason to return COMPACT_PARTIAL is that we think the
> allocation should succeed. This patch distinguishes the premature ending
> condition. Further distinguishing the exact reason seems unnecessary for now.

isolate_migratepages() could return ISOLATE_ABORT and skip to call
compact_finished(). trace_mm_compaction_end() will print
COMPACT_PARTIAL in this case and we cannot distinguish premature
ending condition. Is it okay?

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/3] mm, compaction: disginguish contended status in tracepoint Vlastimil Babka <vbabka@suse.cz> - 2015-08-27 17:30 +0200
  Re: [PATCH 3/3] mm, compaction: disginguish contended status in  tracepoint Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-09-07 08:00 +0200
    Re: [PATCH 3/3] mm, compaction: disginguish contended status in  tracepoint Vlastimil Babka <vbabka@suse.cz> - 2015-09-08 18:30 +0200

csiph-web