Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219871

Re: [PATCH v7 2/3] KVM: dynamic halt-polling

Show all headers | View raw

On 9/6/15 10:32 PM, Paolo Bonzini wrote:
>
> On 05/09/2015 00:38, Wanpeng Li wrote:
>>> @@ -1940,11 +1975,16 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
>>>                 * arrives.
>>>                 */
>>>                if (kvm_vcpu_check_block(vcpu) < 0) {
>>> +                polled = true;
>>>                    ++vcpu->stat.halt_successful_poll;
>>> -                goto out;
>>> +                break;
>>>                }
>>>                cur = ktime_get();
>>>            } while (single_task_running() && ktime_before(cur, stop));
>>> +
>>> +        poll_ns = ktime_to_ns(cur) - ktime_to_ns(start);
>>> +        if (polled)
>>> +            goto out;
>>>
>> Please move poll_ns caculation under if() when you applied, as I
>> explained in reply to v6.
> You can do much more than just that, the patch reduces to this:
>

Cool, many thanks for your help, Paolo! :)

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 2/3] KVM: dynamic halt-polling Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-04 02:20 +0200
  Re: [PATCH v7 2/3] KVM: dynamic halt-polling Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-05 00:40 +0200
    Re: [PATCH v7 2/3] KVM: dynamic halt-polling Paolo Bonzini <pbonzini@redhat.com> - 2015-09-06 16:40 +0200
      Re: [PATCH v7 2/3] KVM: dynamic halt-polling Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-07 00:30 +0200

csiph-web