Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219823

Re: [PATCH] net/core/sysctl_net_core.c unused variable

From Nick Warne <nick@linicks.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net/core/sysctl_net_core.c unused variable
Date 2015-09-06 17:20 +0200
Message-ID <q5JTz-2tP-15@gated-at.bofh.it> (permalink)
References <q5J7c-1k0-7@gated-at.bofh.it> <q5JAd-1RS-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 06/09/15 15:52, Joe Perches wrote:
> On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote:
>> gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but
>> not used in file net/core/sysctl_net_core.c.
>
> Only when CONFIG_NET isn't set.

CONFIG_NET=y

Peculiar indeed.

>> Reading the file, that is
>> the case.  Attached is a patch to remove it.
>
> $ git grep -w -n one net/core/sysctl_net_core.c
> net/core/sysctl_net_core.c:26:static int one = 1;
> net/core/sysctl_net_core.c:332:         .extra2         = &one
>
>> Signed-off-by:  Nick Warne <nick@linicks.net>
>
> Please use grep to augment reading.

grep -w -n one net/core/sysctl_net_core.c
26:static int one = 1;

?

I just don't have the &one.

I am confused now.

Nick
-- 
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/core/sysctl_net_core.c  unused variable Nick Warne <nick@linicks.net> - 2015-09-06 16:30 +0200
  Re: [PATCH] net/core/sysctl_net_core.c  unused variable Joe Perches <joe@perches.com> - 2015-09-06 17:00 +0200
    Re: [PATCH] net/core/sysctl_net_core.c  unused variable Nick Warne <nick@linicks.net> - 2015-09-06 17:20 +0200
      Re: [PATCH] net/core/sysctl_net_core.c  unused variable Nick Warne <nick@linicks.net> - 2015-09-06 17:40 +0200
        Re: [PATCH] net/core/sysctl_net_core.c  unused variable Joe Perches <joe@perches.com> - 2015-09-06 18:00 +0200
          Re: [PATCH] net/core/sysctl_net_core.c  unused variable Nick Warne <nick@linicks.net> - 2015-09-06 18:10 +0200

csiph-web