Re: [PATCH] null_blk: fix memory leak on cleanup

From	Matias Bjorling <m@bjorling.me>
Newsgroups	linux.kernel
Subject	Re: [PATCH] null_blk: fix memory leak on cleanup
Date	2015-09-03 07:50 +0200
Message-ID	<q4vzk-2Si-3@gated-at.bofh.it> (permalink)
References	<q3we5-7pO-7@gated-at.bofh.it> <q4lgB-4Zd-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Den 02-09-2015 kl. 20:39 skrev Ross Zwisler:
> On Mon, Aug 31, 2015 at 02:17:18PM +0200, Matias Bjørling wrote:
>> From: Matias Bjørling <mb@lightnvm.io>
>>
>> Driver was not freeing the memory allocated for internal nullb queues.
>> This patch frees the memory during driver unload.
>
> You may want to consider devm_* style allocations instead.  These are freed
> automatically on driver unload, simplifying your error paths and your unload
> logic as well as preventing leaks.
>
> See this patch for an example:
>
> https://lkml.org/lkml/2015/8/10/992
>

Thanks for looking through the patches. I'll look into it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] null_blk: fix memory leak on cleanup Matias Bjørling <m@bjorling.me> - 2015-08-31 14:20 +0200
  Re: [PATCH] null_blk: fix memory leak on cleanup Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-09-02 20:50 +0200
    Re: [PATCH] null_blk: fix memory leak on cleanup Matias Bjorling <m@bjorling.me> - 2015-09-03 07:50 +0200

csiph-web