Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218032

Re: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module

Show all headers | View raw

On 03.09.2015 13:10, Anand Moon wrote:
> S3C2410_WATCHDOG watchdog drivers should not be loaded automatically,
> but only if a watchdog daemon is installed.

First of all: why?

Secondly: even as a module driver could be loaded automatically to match
enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it
does not hurt - watchdog should be inactive:

s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq
disabled

Best regards,
Krzysztof

> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  arch/arm/configs/exynos_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index aaf7aa4..b5d382e 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
>  CONFIG_THERMAL_EMULATION=y
>  CONFIG_EXYNOS_THERMAL=y
>  CONFIG_WATCHDOG=y
> -CONFIG_S3C2410_WATCHDOG=y
> +CONFIG_S3C2410_WATCHDOG=m
>  CONFIG_MFD_CROS_EC=y
>  CONFIG_MFD_CROS_EC_I2C=y
>  CONFIG_MFD_CROS_EC_SPI=y
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module Anand Moon <linux.amoon@gmail.com> - 2015-09-03 06:20 +0200
  Re: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable  module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-03 07:10 +0200
    Re: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module Anand Moon <linux.amoon@gmail.com> - 2015-09-03 07:30 +0200
      Re: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable  module Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-04 08:50 +0200

csiph-web