Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218000

The tick when exit idle for nohz_full cpu

Show all headers | View raw

Hi, Frederic
	I noticed currently the tick_nohz_idle_exit() will always restart the sched_tick, even when it's on the nohz_full cpu. I'm not sure if we can keep the sched_tick stopped if it's on a nohz_full_cpu. The sched tick will be enabled on tick_nohz_task_switch() if needed. Is it ok to keep the sched tick off in the scheduling process?

	Something like followed patch (just to show the idea).

Thanks
--jyh

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 3319e16..7519a0f 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -909,8 +909,9 @@ void tick_nohz_idle_exit(void)
                tick_nohz_stop_idle(ts, now);

        if (ts->tick_stopped) {
-               tick_nohz_restart_sched_tick(ts, now);
                tick_nohz_account_idle_ticks(ts);
+               if (!tick_nohz_full_cpu(smp_processor_id()))
+                       tick_nohz_restart_sched_tick(ts, now);
        }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

The tick when exit idle for nohz_full cpu "Jiang, Yunhong" <yunhong.jiang@intel.com> - 2015-09-03 03:50 +0200

csiph-web