Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1217835

Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector

Show all headers | View raw

On Wed, 2 Sep 2015, Pinski, Andrew wrote:
> > On Sep 3, 2015, at 1:12 AM, Catalin Marinas <catalin.marinas@arm.com> wrote:
> >> On Wed, Sep 02, 2015 at 10:52:05PM +0800, Andrew Pinski wrote:
> >> That is not a bad idea.  Put this array in the data section of the
> >> VDSO too.  It should be small enough though on systems with 96 or more
> >> cores (dual socket ThunderX has 96 cores total), it is slightly
> >> getting big.
> >> The struct would be something like:
> >> struct
> >> {
> >>  int32 numcores;
> >>  int32 midr[];
> >> };
> > 
> > First of all, I'm against hard-coding (VDSO) data as ABI. So far we used
> > VDSO to override some weak glibc functions but the VDSO-specific data is
> > parsed by the VDSO function implementation and not directly by glibc (or
> > user space). I prefer helper functions that read the VDSO-internal data
> > structures.
> 
> You don't like the idea of a fixed structure ABI that resides inside
> vdso data? Having a fixed struct ABI should be ok.  The location
> inside the data part was going to be passed via an aux vector entry.
> Userland does even need to know it is really located in the vdso at
> all. It just happens to reside in there. The data structure would be
> well defined for the aux vector.

Restrict the VDSO ABI to well defined single purpose functions. It's
way harder to define data struct ABIs right from the beginning.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Andrew Pinski <apinski@cavium.com> - 2015-08-29 20:50 +0200
  Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Mark Rutland <mark.rutland@arm.com> - 2015-09-01 18:40 +0200
    Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector pinskia@gmail.com - 2015-09-01 19:00 +0200
      Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Mark Rutland <mark.rutland@arm.com> - 2015-09-01 19:20 +0200
        Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com> - 2015-09-01 20:10 +0200
      Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com> - 2015-09-01 19:30 +0200
        Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Mark Rutland <mark.rutland@arm.com> - 2015-09-01 19:40 +0200
          Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector pinskia@gmail.com - 2015-09-01 20:00 +0200
            Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Siarhei Siamashka <siarhei.siamashka@gmail.com> - 2015-09-01 21:20 +0200
              Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com> - 2015-09-02 02:30 +0200
                Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Siarhei Siamashka <siarhei.siamashka@gmail.com> - 2015-09-02 16:00 +0200
                Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Andrew Pinski <andrew.pinski@caviumnetworks.com> - 2015-09-02 17:00 +0200
                Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Catalin Marinas <catalin.marinas@arm.com> - 2015-09-02 19:20 +0200
                Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com> - 2015-09-02 19:40 +0200
                Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Thomas Gleixner <tglx@linutronix.de> - 2015-09-02 22:20 +0200
                Re: [PATCHv2] ARM64: Add AT_ARM64_MIDR to the aux vector Catalin Marinas <catalin.marinas@arm.com> - 2015-09-03 19:20 +0200

csiph-web