Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

From	Andreas Gruenbacher <agruenba@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags
Date	2015-09-02 21:10 +0200
Message-ID	<q4lzY-5B5-13@gated-at.bofh.it> (permalink)
References	<pTJ2V-1c2-3@gated-at.bofh.it> <pTJmi-1OA-25@gated-at.bofh.it> <q4lqi-5as-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2015-09-02 20:53 GMT+02:00 J. Bruce Fields <bfields@fieldses.org>:
>> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, struct inode *inode, int mask)
>>   * this, letting us set arbitrary permissions for filesystem access without
>>   * changing the "normal" UIDs which are used for other things.
>>   *
>> - * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask.
>> + * When checking for MAY_APPEND, MAY_CREATE_FILE, MAY_CREATE_DIR,
>> + * MAY_WRITE must also be set in @mask.
>
> Why?

So that file systems that don't support MAY_APPEND can ignore the flag
and will then automatically check for MAY_WRITE instead.

> (Also: written as a simple list like that, it's a ambiguous how to
> parse that comment: I think you mean that MAY_WRITE must be set whenever
> MAY_APPEND, MAY_CREATE_FILE, or MAY_CREATE_DIR are set.)

Yes, that's better.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR  permission flags bfields@fieldses.org (J. Bruce Fields) - 2015-09-02 21:00 +0200
  Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR  permission flags Andreas Gruenbacher <agruenba@redhat.com> - 2015-09-02 21:10 +0200
    Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR  permission flags "J. Bruce Fields" <bfields@fieldses.org> - 2015-09-02 21:30 +0200
      Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR  permission flags Andreas Gruenbacher <agruenba@redhat.com> - 2015-09-02 22:30 +0200

csiph-web