Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1217690

Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios

Show all headers | View raw

Hi Rob,

On Tue, 01 Sep 2015, Rob Herring wrote:

> On Tue, Sep 1, 2015 at 3:32 AM, Javier Martinez Canillas
> <javier@dowhile0.org> wrote:
> > Hello Peter,
> >
> > On Fri, Aug 28, 2015 at 7:52 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> >> gpio.txt documents that GPIO properties should be named
> >> "[<name>-]gpios", with <name> being the purpose of this
> >> GPIO for the device.
> >>
> >> This change has been done as one atomic commit.
> >>
> >> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> >> Acked-by: Lee Jones <lee.jones@linaro.org>
> >> ---
> >>  Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++---
> >>  arch/arm/boot/dts/stihxxx-b2120.dtsi                          | 4 ++--
> >>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c         | 2 +-
> >>  3 files changed, 6 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> >> index d4def76..e70d840 100644
> >> --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> >> +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> >> @@ -35,7 +35,7 @@ Required properties (tsin (child) node):
> >>
> >>  - tsin-num     : tsin id of the InputBlock (must be between 0 to 6)
> >>  - i2c-bus      : phandle to the I2C bus DT node which the demodulators & tuners on this tsin channel are connected.
> >> -- rst-gpio     : reset gpio for this tsin channel.
> >> +- reset-gpios  : reset gpio for this tsin channel.
> >
> > The documentation is a bit outdated, the GPIO subsystem supports both
> > -gpio and -gpios, see commit:
> >
> > dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names")
> 
> Yes, because we have lots of them.
> 
> > So it makes sense to me to use -gpio instead of -gpios in this case
> > since is a single GPIO. Also rst is already a descriptive name since
> > that's how many datasheets name a reset pin. I'm not saying I'm
> > against this patch, just pointing out since the commit message is a
> > bit misleading.
> 
> I believe that this has been discussed at length and it was decided
> that new bindings should use "-gpios" even for 1. Just like "clocks"
> is always plural.

Doh! Ok I will change back again to 'reset-gpios'.

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Peter Griffin <peter.griffin@linaro.org> - 2015-08-28 20:00 +0200
  Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Rob Herring <robherring2@gmail.com> - 2015-08-31 17:30 +0200
    Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Lee Jones <lee.jones@linaro.org> - 2015-09-01 10:00 +0200
    Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Peter Griffin <peter.griffin@linaro.org> - 2015-09-01 12:20 +0200
  Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Javier Martinez Canillas <javier@dowhile0.org> - 2015-09-01 10:40 +0200
    Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Lee Jones <lee.jones@linaro.org> - 2015-09-01 11:10 +0200
      Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Javier Martinez Canillas <javier@dowhile0.org> - 2015-09-01 11:20 +0200
        Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Lee Jones <lee.jones@linaro.org> - 2015-09-01 11:30 +0200
        Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Peter Griffin <peter.griffin@linaro.org> - 2015-09-01 12:40 +0200
          Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Lee Jones <lee.jones@linaro.org> - 2015-09-01 14:20 +0200
    Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Rob Herring <robherring2@gmail.com> - 2015-09-01 14:00 +0200
      Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Javier Martinez Canillas <javier@dowhile0.org> - 2015-09-01 14:40 +0200
      Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Peter Griffin <peter.griffin@linaro.org> - 2015-09-02 17:10 +0200

csiph-web