Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1217686

Re: [PATCH] reset: Fix of_reset_control_get() for consistent return values

Show all headers | View raw

Hi Alban,

Am Dienstag, den 01.09.2015, 17:28 +0200 schrieb Alban Bedel:
> When of_reset_control_get() is called without connection ID it returns
> -ENOENT when the 'resets' property doesn't exists or is an empty entry.
> However when a connection ID is given it returns -EINVAL when the 'resets'
> property doesn't exists or the requested name can't be found. This is
> because the error code returned by of_property_match_string() is just
> passed down as an index to of_parse_phandle_with_args(), which then
> returns -EINVAL.

Is that true? As far as I can see, since commit bd69f73f2c81
("of: Create function for counting number of phandles in a property")
it returns the (positive) number of entries if index is negative and the
'resets' property exists and parses correctly (before it would return
-ENOENT). If there are parsing errors, it can also return -EINVAL.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] reset: Fix of_reset_control_get() for consistent return values Alban Bedel <albeu@free.fr> - 2015-09-01 17:30 +0200
  Re: [PATCH] reset: Fix of_reset_control_get() for consistent return  values Philipp Zabel <p.zabel@pengutronix.de> - 2015-09-02 17:10 +0200
    Re: [PATCH] reset: Fix of_reset_control_get() for consistent return  values Alban <albeu@free.fr> - 2015-09-02 18:40 +0200
      Re: [PATCH] reset: Fix of_reset_control_get() for consistent return  values Philipp Zabel <p.zabel@pengutronix.de> - 2015-09-03 11:50 +0200

csiph-web