Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator
Date	2015-09-02 13:20 +0200
Message-ID	<q4ef7-3r7-1@gated-at.bofh.it> (permalink)
References	(5 earlier) <q3yIX-2rV-39@gated-at.bofh.it> <q3Qmu-2NS-19@gated-at.bofh.it> <q3UzM-w6-9@gated-at.bofh.it> <q3YDo-6fB-23@gated-at.bofh.it> <q3YWK-6Cc-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 01, 2015 at 11:56:06AM -0700, Tony Lindgren wrote:
> * Mark Brown <broonie@kernel.org> [150901 11:40]:

> > That'd work.  The other thing I was thinking we could do is to get
> > syscon to treat any excessively large address that gets passed in that
> > looks like an absolute address appropriately.

> Hmm wouldn't that get messy for 64-bit :) How about something
> like:

Meh, it'd probably be fine - I was thinking falling back to trying to
substract the base address if the passed address was out of bounds.
It's not super elegant though, something that directly does the right
thing would be better.

> unsigned long syscon_regmap_get_offset(struct regmap *syscon,
> 					void __iomem *base)

> Not sure if that's something that some drivers would start to
> misuse with read/writel though.. Presumably not if the driver
> already is using syscon.

It should be really easy to spot abuse I'd hope.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program  pbias regulator Grygorii Strashko <grygorii.strashko@ti.com> - 2015-08-25 12:10 +0200
  Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Mark Brown <broonie@kernel.org> - 2015-08-25 16:00 +0200
    Re: [PATCH 1/2] regulator: pbias: use untranslated address to program  pbias regulator Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-31 12:50 +0200
      Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Mark Brown <broonie@kernel.org> - 2015-08-31 17:00 +0200
        Re: [PATCH 1/2] regulator: pbias: use untranslated address to program  pbias regulator Kishon Vijay Abraham I <kishon@ti.com> - 2015-09-01 11:50 +0200
          Re: [PATCH 1/2] regulator: pbias: use untranslated address to program  pbias regulator Kishon Vijay Abraham I <kishon@ti.com> - 2015-09-01 13:40 +0200
          Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Tony Lindgren <tony@atomide.com> - 2015-09-01 16:20 +0200
            Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Mark Brown <broonie@kernel.org> - 2015-09-01 20:40 +0200
              Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Tony Lindgren <tony@atomide.com> - 2015-09-01 21:00 +0200
                Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Mark Brown <broonie@kernel.org> - 2015-09-02 13:20 +0200

csiph-web