Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218941

Re: [PATCH v3] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()

Show all headers | View raw

On Thu, 20 Aug 2015, Alexander Kuleshov wrote:

> The debugfs_create_dir() and debugfs_create_file() functions may return -errno
> if an error occurs. This patch adds a couple of checks of the result of the
> debufs_create_dir() and debugfs_create_file() functions execution in the
> hid_debug_register() and othre places.
> 
> Changelog:
> 
> v3:
> 
>   * do not check hid_debug before the call of the hid_debug_init()
> and hid_debug_exit() from v2
> 
> v2:
> 
>   * add check for the result of the debugfs_create_file() calls
>   * call hid_debug_init() and hid_debug_exit() only if hid_debug
>   * add check for the hid_debug_root in the hid_debug_register()
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>

Did you try to even compile-test your patch?

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file() Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-20 19:40 +0200
  Re: [PATCH v3] drivers/hid: Check result of debugfs_create_dir()  and debugfs_create_file() Jiri Kosina <jikos@kernel.org> - 2015-09-04 15:20 +0200
    Re: [PATCH v3] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file() Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-09-04 15:40 +0200

csiph-web