Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218887

Re: [PATCH] mac80211: Do not use sizeof() on pointer type

Show all headers | View raw

On Wed, 2015-08-26 at 12:22 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The rate_control_cap_mask() function takes a parameter mcs_mask, 
> which
> GCC will take to be u8 * even though it was declared with a fixed 
> size.
> This causes the following warning:
> 
> 	net/mac80211/rate.c: In function 'rate_control_cap_mask':
> 	net/mac80211/rate.c:719:25: warning: 'sizeof' on array 
> function parameter 'mcs_mask' will return size of 'u8 * {aka unsigned 
> char *}' [-Wsizeof-array-argument]
> 	   for (i = 0; i < sizeof(mcs_mask); i++)
> 	                         ^
> 	net/mac80211/rate.c:684:10: note: declared here
> 	       u8 mcs_mask[IEEE80211_HT_MCS_MASK_LEN],
> 	          ^
> 
> This can be easily fixed by using the IEEE80211_HT_MCS_MASK_LEN 
> directly
> within the loop condition.

Dunno if you (Thierry) saw all the discussion about this - but anyway,
applied, thanks.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: Do not use sizeof() on pointer type Thierry Reding <thierry.reding@gmail.com> - 2015-08-26 12:30 +0200
  Re: [PATCH] mac80211: Do not use sizeof() on pointer type Arend van Spriel <arend@broadcom.com> - 2015-08-26 22:30 +0200
    Re: [PATCH] mac80211: Do not use sizeof() on pointer type Arend van Spriel <arend@broadcom.com> - 2015-08-26 22:50 +0200
  Re: [PATCH] mac80211: Do not use sizeof() on pointer type Johannes Berg <johannes@sipsolutions.net> - 2015-09-04 14:30 +0200

csiph-web