Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1218903
| From | Vitaly Kuznetsov <vkuznets@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size() |
| Date | 2015-09-04 15:00 +0200 |
| Message-ID | <q4YL0-2vD-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
string_get_size(1, 512, 0, ..., ...) call results in an infinite loop. The problem is that if size == 0 when we start calculating sf_cap this loop will never end. The caller causing the issue is sd_read_capacity(), the problem was noticed on Hyper-V. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> --- lib/string_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/string_helpers.c b/lib/string_helpers.c index c98ae81..a155c7b 100644 --- a/lib/string_helpers.c +++ b/lib/string_helpers.c @@ -76,7 +76,7 @@ void string_get_size(u64 size, u64 blk_size, const enum string_size_units units, i++; } - sf_cap = size; + sf_cap = size ? size : 1; for (j = 0; sf_cap*10 < 1000; j++) sf_cap *= 10; -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] lib/string_helpers.c: fix infinite loop in string_get_size() Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-09-04 15:00 +0200
csiph-web