Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling

From	Michal Marek <mmarek@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling
Date	2015-09-04 13:30 +0200
Message-ID	<q4XlV-D8-37@gated-at.bofh.it> (permalink)
References	(2 earlier) <pKtgJ-6zl-3@gated-at.bofh.it> <pLJCN-40p-1@gated-at.bofh.it> <pZdMK-1OT-13@gated-at.bofh.it> <q1Uud-6BL-5@gated-at.bofh.it> <q20SZ-7Bx-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015-08-27 10:37, Michal Marek wrote:
> On 2015-08-27 03:49, Behan Webster wrote:
>> Is there any reason you renamed COMPILER? Because it breaks all the 
>> other patches we have queued up which use it for cross compiling.
>>
>> And aren't we supposed to use all caps for variable names?
> 
> It more like a function now and is consistent with the other cc-*
> definitions in scripts/Kbuild.include.
> 
> 
>> This doesn't only break powerpc, it breaks arm, aarch64 and clang work 
>> that's being done on MIPS malta.
> 
> So do a s/COMPILER/cc-name/ ? You can merge my patch into your tree to
> avoid a dependency on the kbuild tree.

Since I haven't seen any further uses of the $(CLANG) variable in
linux-next, I applied the patch to kbuild.git now.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling Behan Webster <behanw@converseincode.com> - 2015-08-27 03:50 +0200
  Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling Michal Marek <mmarek@suse.cz> - 2015-08-27 10:40 +0200
    Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling Michal Marek <mmarek@suse.cz> - 2015-09-04 13:30 +0200

csiph-web