Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1218620
| From | Wanpeng Li <wanpeng.li@hotmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment |
| Date | 2015-09-04 02:20 +0200 |
| Message-ID | <q4MTw-2tO-21@gated-at.bofh.it> (permalink) |
| References | <q4aOf-6Sb-21@gated-at.bofh.it> <q4aOg-6Sb-41@gated-at.bofh.it> <q4kDU-4f5-9@gated-at.bofh.it> <q4z0e-7Rx-13@gated-at.bofh.it> <q4Ffm-8tV-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 9/4/15 12:07 AM, David Matlack wrote:
> On Thu, Sep 3, 2015 at 2:23 AM, Wanpeng Li <wanpeng.li@hotmail.com> wrote:
>> How about something like:
>>
>> @@ -1941,10 +1976,14 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
>> */
>> if (kvm_vcpu_check_block(vcpu) < 0) {
>> ++vcpu->stat.halt_successful_poll;
>> - goto out;
>> + break;
>> }
>> cur = ktime_get();
>> } while (single_task_running() && ktime_before(cur, stop));
>> +
>> + poll_ns = ktime_to_ns(cur) - ktime_to_ns(start);
>> + if (ktime_before(cur, stop) && single_task_running())
>> + goto out;
> I would prefer an explicit signal (e.g. set a bool to true before breaking out
> of the loop, and check it here) to avoid duplicating the loop exit condition.
Fix it in v7, thanks for your review, David! ;-)
Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-02 09:40 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment David Matlack <dmatlack@google.com> - 2015-09-02 20:10 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Paolo Bonzini <pbonzini@redhat.com> - 2015-09-02 21:20 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment David Matlack <dmatlack@google.com> - 2015-09-02 21:30 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Paolo Bonzini <pbonzini@redhat.com> - 2015-09-03 09:40 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-03 11:00 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-03 11:30 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment David Matlack <dmatlack@google.com> - 2015-09-03 18:10 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-04 02:20 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-04 03:20 +0200
Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment Wanpeng Li <wanpeng.li@hotmail.com> - 2015-09-04 03:50 +0200
csiph-web