Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218552

Re: [PATCH] net: fec: normalize return value of pm_runtime_get_sync() in MDIO write

Show all headers | View raw

On Thu, Sep 03, 2015 at 09:38:30PM +0200, Maciej S. Szmigiero wrote:
> If fec MDIO write method succeeds its return value comes from
> call to pm_runtime_get_sync().
> But pm_runtime_get_sync() can also return 1.
> 
> In case of Micrel KSZ9031 PHY this value will then
> be returned along the call chain of phy_write() ->
> ksz9031_extended_write() -> ksz9031_center_flp_timing() ->
> ksz9031_config_init() -> phy_init_hw() -> phy_attach_direct() ->
> phy_connect_direct().
> 
> Then phy_connect() will cast it into a pointer using ERR_PTR(),
> which then fec_enet_mii_probe() will try to dereference
> resulting in an oops.
> 
> Fix it by normalizing return value of pm_runtime_get_sync()
> to be zero if positive in MDIO write method.
> 
> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>

Fixes: 8fff755e9f8d ("net: fec: Ensure clocks are enabled while using mdio bus")

Acked-by: Andrew Lunn <andrew@lunn.ch>

Thanks
	Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: fec: normalize return value of pm_runtime_get_sync()  in MDIO write "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-09-03 21:40 +0200
  Re: [PATCH] net: fec: normalize return value of  pm_runtime_get_sync() in MDIO write Andrew Lunn <andrew@lunn.ch> - 2015-09-03 22:00 +0200
  Re: [PATCH] net: fec: normalize return value of  pm_runtime_get_sync() in MDIO write David Miller <davem@davemloft.net> - 2015-09-06 07:10 +0200

csiph-web