Re: [STLinux Kernel] [PATCH v3 1/6] ARM: STi: Add DT defines for co-processor reset lines

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Peter Griffin <peter.griffin@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [STLinux Kernel] [PATCH v3 1/6] ARM: STi: Add DT defines for co-processor reset lines
Date	Thu, 03 Sep 2015 18:40:03 +0200
Message-ID	<q4FIn-AC-33@gated-at.bofh.it> (permalink)
References	<q4isq-UW-11@gated-at.bofh.it> <q4isq-UW-15@gated-at.bofh.it>
X-Original-To	Lee Jones <lee.jones@linaro.org>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=uGEhLy0XtgANZNvAE4mB+V/74lVKmHqQJsiYL2bZlks=; b=Ngv0o9k0zWRr92RQQk6pQN1Q17cWJPiMlkTv9+Y4stdal8nrzpeZwXY72lAWCR42I1 CFMjlWEIx3tc07KRQ+q4sRfJtcpDJH3IZ3Lzsb2aDH+VpYVfG0zo2KJlYaBTdD+yqla4 31KuPb5eZ3LuFhVdPwj5ltY0fZsKMNAMncP5gHxS3v8JMvP4iEBz1/SF9/f/nkWf4Xd0 sa7lPL7vKO562pshYtSKk6ywnf9mK3jpqM+7sxXZcLutd1NyM6k4LTYw49XTBAdicBqz QJ8a8EH0XYV2LaUxClo0UypcWg/mxUa12b+ThC3ljExWHTI0oNhR0KrP2ApYcq1ep0X6 h3DQ==
X-Gm-Message-State	ALoCoQl/lTX/kNNnK46yQUgheG9MQvV4PEMa2v0UCS4CiBNG5bCzZwVugBuOfSGyXzJ8Qh4xoPx7
X-Received	by 10.194.134.167 with SMTP id pl7mr38185279wjb.126.1441297892499; Thu, 03 Sep 2015 09:31:32 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ohad@wizery.com, devicetree@vger.kernel.org, f.fainelli@gmail.com, kernel@stlinux.com, Nathan_Lynch@mentor.com
X-Original-Date	Thu, 3 Sep 2015 17:31:29 +0100
X-Original-Message-ID	<20150903163129.GE7093@griffinp-ThinkPad-X1-Carbon-2nd>
X-Original-References	<1441208289-17330-1-git-send-email-lee.jones@linaro.org> <1441208289-17330-2-git-send-email-lee.jones@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1218431

Show key headers only | View raw

Hi Lee,

On Wed, 02 Sep 2015, Lee Jones wrote:

> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  include/dt-bindings/reset-controller/stih407-resets.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/dt-bindings/reset-controller/stih407-resets.h b/include/dt-bindings/reset-controller/stih407-resets.h
> index 02d4328..4ab3a1c 100644
> --- a/include/dt-bindings/reset-controller/stih407-resets.h
> +++ b/include/dt-bindings/reset-controller/stih407-resets.h
> @@ -52,6 +52,10 @@
>  #define STIH407_KEYSCAN_SOFTRESET	26
>  #define STIH407_USB2_PORT0_SOFTRESET	27
>  #define STIH407_USB2_PORT1_SOFTRESET	28
> +#define STIH407_ST231_AUD_SOFTRESET	29
> +#define STIH407_ST231_DMU_SOFTRESET	30
> +#define STIH407_ST231_GP0_SOFTRESET	31
> +#define STIH407_ST231_GP1_SOFTRESET	32

You've added the #defines, so the DT should compile with v3.

However you don't appear to have added the code which
uses these #defines to drivers/reset/reset-stih407.c. So v3
still won't take the co-processors out of reset.

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/6] ARM: STi: Add DT defines for co-processor reset lines Lee Jones <lee.jones@linaro.org> - 2015-09-02 17:50 +0200
  Re: [STLinux Kernel] [PATCH v3 1/6] ARM: STi: Add DT defines for  co-processor reset lines Peter Griffin <peter.griffin@linaro.org> - 2015-09-03 18:40 +0200

csiph-web