Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218366

[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL

Show all headers | View raw

If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module,
the following build error is seen for arm:allmodconfig and
arm64:allmodconfig.

drivers/built-in.o: In function `mtk_cpufreq_ready':
:(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register'
drivers/built-in.o: In function `mtk_cpufreq_exit':
:(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister'

The fix is similar to CPUFREQ_DT, but more restrictive since
ARM_MT8173_CPUFREQ can not be built as module.

Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
It might also make sense to declare ARM_MT8173_CPUFREQ as tristate
and relax the conditions, but I don't know if that is feasible.

 drivers/cpufreq/Kconfig.arm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 77aa34eae92c..c4c6200be435 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -133,6 +133,7 @@ config ARM_KIRKWOOD_CPUFREQ
 config ARM_MT8173_CPUFREQ
 	bool "Mediatek MT8173 CPUFreq support"
 	depends on ARCH_MEDIATEK && REGULATOR
+	depends on !CPU_THERMAL || THERMAL=y
 	select PM_OPP
 	help
 	  This adds the CPUFreq driver support for Mediatek MT8173 SoC.
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL Guenter Roeck <linux@roeck-us.net> - 2015-09-03 17:30 +0200
  Re: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-03 18:00 +0200
    Re: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL Olof Johansson <olof@lixom.net> - 2015-09-04 21:10 +0200
      Re: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL Guenter Roeck <linux@roeck-us.net> - 2015-09-04 21:50 +0200
      Re: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-05 00:30 +0200

csiph-web