Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218256

Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1

Show all headers | View raw

On 2015/9/3 20:54, Mark Brown wrote:
> On Tue, Sep 01, 2015 at 05:58:44PM +0800, Shawn Lin wrote:
>
>> Generic dma controller on Rockchips' platform cannot support
>> DMAFLUSHP instruction which make dma to flush the req of non-aligned
>> or non-multiple of what we need. That will cause an unrecoverable
>> dma bus error. The saftest way is to set dma max burst to 1.
>
> If this is a quirk of the DMA controller why is it being fixed with a
> property specific to the SPI controller?  Can't the DMA controller just
> override the burst size?
>

Cool...that's a good question. Actually DMA controller can't do that 
since block peripheral controller(e.g sd/emmc, they always access data 
by block-512Bytes.) can't meet the case. So It's hard for dma controller 
know who is the caller, and what should be done.

The only thing dma controller can do is avoid to execute DMAFLUSHP on 
its own. But how about peripheral controller trigger non-multiple 
access? So that's what I mentioned on covery letter that we should do 
"broken things" for both dma controller and some peripherals.

>> +#define ROCKCHIP_SPI_BORKEN_BURST_LEN (1<<0) /* broken burst len*/
>
> This is misspelt.

Woops, sorry for the bit. Thanks, Mark.

>


-- 
Best Regards
Shawn Lin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] Fix broken DMAFLUSHP on Rockchips platform Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:00 +0200
  [PATCH v3 6/9] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3288 platform Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:00 +0200
  [PATCH v3 5/9] DMA: pl330: add quirk for broken no flushp Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:00 +0200
  [PATCH v3 1/9] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:00 +0200
  [PATCH v3 2/9] Documentation: arm-pl330: add description of arm,pl330-broken-no-flushp Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:00 +0200
  [PATCH v3 3/9] Documentation: spi-rockchip: add description of rockchip,spi-broken-burst-len Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:00 +0200
  [PATCH v3 7/9] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3xxx platform Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:00 +0200
  [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1 Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:10 +0200
    Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1 Mark Brown <broonie@kernel.org> - 2015-09-03 15:00 +0200
      Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1 Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-03 15:50 +0200
        Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1 Mark Brown <broonie@kernel.org> - 2015-09-03 20:50 +0200
          Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1 Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-04 02:10 +0200
  [PATCH v3 9/9] ASoC: rockchip_i2s: modify DMA max burst to 1 Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-01 12:10 +0200

csiph-web