Re: [PATCH v3 1/4] perf tests: take into account address of each objdump line

From	Adrian Hunter <adrian.hunter@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/4] perf tests: take into account address of each objdump line
Date	2015-09-03 13:40 +0200
Message-ID	<q4B23-2jJ-31@gated-at.bofh.it> (permalink)
References	<q4yQy-7Gl-23@gated-at.bofh.it> <q4ASm-28C-25@gated-at.bofh.it>
Organization	Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw

On 03/09/15 14:23, Jan Stancek wrote:
> objdump output can contain repeated bytes. At the moment test reads
> all output sequentially, assuming each address is represented in
> output only once:
> 
>   ffffffff8164efb3 <retint_swapgs+0x9>:
>   ffffffff8164efb3:  c1 5d 00 eb        rcrl   $0xeb,0x0(%rbp)
>   ffffffff8164efb7:  00 4c 8b 5c        add    %cl,0x5c(%rbx,%rcx,4)
> 
>   ffffffff8164efb8 <restore_c_regs_and_iret>:
>   ffffffff8164efb8:  4c 8b 5c 24 30     mov    0x30(%rsp),%r11
>   ffffffff8164efbd:  4c 8b 54 24 38     mov    0x38(%rsp),%r10
> 
> Store objdump output to buffer according to offset calculated
> from address on each line.
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
>  tools/perf/tests/code-reading.c | 53 +++++++++++++++++++++++++++++++----------
>  1 file changed, 40 insertions(+), 13 deletions(-)
> 
> Changes in v3:
>   align read_objdump_line parameters on 2nd line
>   fix multiline comment
>   replace MIN with min
> 

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/4] perf tests: take into account address of each objdump line Jan Stancek <jstancek@redhat.com> - 2015-09-02 10:20 +0200
  [PATCH v2 3/4] perf tests: stop reading if objdump output crossed sections Jan Stancek <jstancek@redhat.com> - 2015-09-02 10:30 +0200
    Re: [PATCH v2 3/4] perf tests: stop reading if objdump output crossed  sections Adrian Hunter <adrian.hunter@intel.com> - 2015-09-03 11:20 +0200
  Re: [PATCH v2 1/4] perf tests: take into account address of each  objdump line Adrian Hunter <adrian.hunter@intel.com> - 2015-09-03 11:20 +0200
    [PATCH v3 1/4] perf tests: take into account address of each objdump line Jan Stancek <jstancek@redhat.com> - 2015-09-03 13:30 +0200
      Re: [PATCH v3 1/4] perf tests: take into account address of each  objdump line Adrian Hunter <adrian.hunter@intel.com> - 2015-09-03 13:40 +0200

csiph-web