[PATCH] crypto/testmgr: don't copy from source IV too much

From	Andrey Ryabinin <aryabinin@odin.com>
Newsgroups	linux.kernel
Subject	[PATCH] crypto/testmgr: don't copy from source IV too much
Date	2015-09-03 13:40 +0200
Message-ID	<q4B22-2jJ-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

While the destination buffer 'iv' is MAX_IVLEN size,
the source 'template[i].iv' could be smaller. Thus
copying it via memcpy() leads to invalid memory access.
Use strlcpy() instead.

Signed-off-by: Andrey Ryabinin <aryabinin@odin.com>
---
 crypto/testmgr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index d0a42bd..d85221c 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -974,7 +974,7 @@ static int __test_skcipher(struct crypto_ablkcipher *tfm, int enc,
 			continue;
 
 		if (template[i].iv)
-			memcpy(iv, template[i].iv, MAX_IVLEN);
+			strlcpy(iv, template[i].iv, MAX_IVLEN);
 		else
 			memset(iv, 0, MAX_IVLEN);
 
@@ -1049,7 +1049,7 @@ static int __test_skcipher(struct crypto_ablkcipher *tfm, int enc,
 			continue;
 
 		if (template[i].iv)
-			memcpy(iv, template[i].iv, MAX_IVLEN);
+			strlcpy(iv, template[i].iv, MAX_IVLEN);
 		else
 			memset(iv, 0, MAX_IVLEN);
 
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto/testmgr: don't copy from source IV too much Andrey Ryabinin <aryabinin@odin.com> - 2015-09-03 13:40 +0200
  Re: [PATCH] crypto/testmgr: don't copy from source IV too much Herbert Xu <herbert@gondor.apana.org.au> - 2015-09-03 15:30 +0200
    Re: [PATCH] crypto/testmgr: don't copy from source IV too much Andrey Ryabinin <aryabinin@odin.com> - 2015-09-04 18:50 +0200
      Re: [PATCH] crypto/testmgr: don't copy from source IV too much Herbert Xu <herbert@gondor.apana.org.au> - 2015-09-05 04:10 +0200

csiph-web