Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces

From	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces
Date	2015-09-02 00:20 +0200
Message-ID	<q424i-2Oo-3@gated-at.bofh.it> (permalink)
References	<pXh85-2TO-3@gated-at.bofh.it> <pXh86-2TO-23@gated-at.bofh.it> <q3R8R-3Y0-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Peter Zijlstra [peterz@infradead.org] wrote:
| 
| when looking at this (I almost pressed A for apply) it occurred to me
| that we now keep double state, cpuhw->txn_flags and cpuhw->group_flag
| are basically the same thing.
| 
| Would not something like the below avoid this duplication?

Yes, it makes sense to drop the duplication. Will similarly drop the usage
of PERF_EVENT_TXN from other architectures too and try it out.

Thanks,

Sukadev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces Peter Zijlstra <peterz@infradead.org> - 2015-09-01 12:40 +0200
  Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2015-09-02 00:20 +0200

csiph-web