Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1217076

Re: Regression: can't apply frequency offsets above 1000ppm.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 1 Sep 2015, John Stultz wrote:
> On Tue, Sep 1, 2015 at 1:25 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Tue, 1 Sep 2015, Nuno Gonçalves wrote:
> >
> >> There is a regression on the clock system since v3.16-rc5-111-g4396e05
> >> [1],
> >
> >> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4396e058c52e167729729cf64ea3dfa229637086
> >
> > That commit has absolutely nothing to do with NTP. I fear your bisect
> > went down the wrong road somewhere.
> >
> >> where the clock doesn't apply frequency offsets above about
> >> 1000ppm [2].
> >
> > This looks pretty familiar.
> >
> > The issue was introduced with commit 5e5aeb4367b (time: adjtimex:
> > Validate the ADJ_FREQUENCY values). That patch was tagged for stable,
> > so it got backported.
> >
> > The fix is in commit 29183a70b0b82 (ntp: Fixup adjtimex freq
> > validation on 32-bit systems). That commit was tagged for stable as
> > well, but with the extra '#3.19+' limitation.
> >
> > So in the worst case 5e5aeb4367b hit a stable tree < 3.19, but
> > 29183a70b0b82 did not.
> 
> Hrm. So that would be problematic, and I'll have to follow up that
> both changes got backported together.
> 
> But I don't think that's the issue here, since the problem supposedly
> continues w/ 4.2...

Duh, missed that part.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Regression: can't apply frequency offsets above 1000ppm. Nuno Gonçalves <nunojpg@gmail.com> - 2015-09-01 22:10 +0200
  Re: Regression: can't apply frequency offsets above 1000ppm. Thomas Gleixner <tglx@linutronix.de> - 2015-09-01 22:30 +0200
    Re: Regression: can't apply frequency offsets above 1000ppm. John Stultz <john.stultz@linaro.org> - 2015-09-01 22:40 +0200
      Re: Regression: can't apply frequency offsets above 1000ppm. Thomas Gleixner <tglx@linutronix.de> - 2015-09-01 22:50 +0200
    Re: Regression: can't apply frequency offsets above 1000ppm. Nuno Gonçalves <nunojpg@gmail.com> - 2015-09-02 02:40 +0200
      Re: Regression: can't apply frequency offsets above 1000ppm. John Stultz <john.stultz@linaro.org> - 2015-09-02 03:10 +0200
        Re: Regression: can't apply frequency offsets above 1000ppm. Nuno Gonçalves <nunojpg@gmail.com> - 2015-09-02 03:20 +0200
          Re: Regression: can't apply frequency offsets above 1000ppm. Miroslav Lichvar <mlichvar@redhat.com> - 2015-09-02 09:40 +0200
          Re: Regression: can't apply frequency offsets above 1000ppm. John Stultz <john.stultz@linaro.org> - 2015-09-03 01:20 +0200
            Re: Regression: can't apply frequency offsets above 1000ppm. Nuno Gonçalves <nunojpg@gmail.com> - 2015-09-03 12:20 +0200
            Re: Regression: can't apply frequency offsets above 1000ppm. Miroslav Lichvar <mlichvar@redhat.com> - 2015-09-03 13:30 +0200
              Re: Regression: can't apply frequency offsets above 1000ppm. John Stultz <john.stultz@linaro.org> - 2015-09-05 03:00 +0200
                Re: Regression: can't apply frequency offsets above 1000ppm. John Stultz <john.stultz@linaro.org> - 2015-09-05 03:10 +0200
                defects for uses of abs(u64) (was: Re: Regression: can't apply  frequency offsets above 1000ppm) Joe Perches <joe@perches.com> - 2015-09-05 03:50 +0200
                Re: Regression: can't apply frequency offsets above 1000ppm. Nuno Gonçalves <nunojpg@gmail.com> - 2015-09-05 15:50 +0200
  Re: Regression: can't apply frequency offsets above 1000ppm. John Stultz <john.stultz@linaro.org> - 2015-09-01 22:30 +0200

csiph-web