Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216265

Re: [RFC v6 10/40] richacl: Permission check algorithm

Show all headers | View raw

On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote:
> 2015-08-28 23:49 GMT+02:00 J. Bruce Fields <bfields@fieldses.org>:
> > On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote:
> >> +             /*
> >> +              * We don't care which class the process is in when the acl is
> >> +              * not masked.
> >> +              */
> >> +             in_owner_or_group_class = 1;
> >
> > So why bother setting it at all, then?  Oh, I see, it lets you break out
> > of the loop below earlier.  OK.
> 
> Comment changed to:
> 
>                 /*
>                  * When the acl is not masked, there is no need to determine if
>                  * the process is in the group class and we can earlier break
>                  * out of the loop below.
>                  */

makes sense, just replace "earlier break out" by "break out earlier".

> 
> > Patch makes sense to me, ACK.
> 
> Thanks,
> Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v6 10/40] richacl: Permission check algorithm bfields@fieldses.org (J. Bruce Fields) - 2015-08-28 23:50 +0200
  Re: [RFC v6 10/40] richacl: Permission check algorithm Andreas Grünbacher <andreas.gruenbacher@gmail.com> - 2015-08-29 00:10 +0200
    Re: [RFC v6 10/40] richacl: Permission check algorithm "J. Bruce Fields" <bfields@fieldses.org> - 2015-08-31 17:30 +0200

csiph-web