Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216285

Re: [PATCH] reset: Add (devm_)reset_control_get stub functions

Show all headers | View raw

Hi Axel,

thank you for the patch.

Am Montag, den 31.08.2015, 17:22 +0800 schrieb Axel Lin:
> So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  include/linux/reset.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index da5602b..cd42c1b 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -74,6 +74,18 @@ static inline int device_reset_optional(struct device *dev)
>  	return -ENOSYS;
>  }
>  
> +static inline struct reset_control *reset_control_get(
> +					struct device *dev, const char *id)
> +{
> +	return ERR_PTR(-ENOSYS);
> +}
> +
> +static inline struct reset_control *devm_reset_control_get(
> +					struct device *dev, const char *id)
> +{
> +	return ERR_PTR(-ENOSYS);
> +}
> +

Could you add a WARN_ON(1) to both, make them __must_check, and return
something other than -ENOSYS. For example the gpio stubs return -EINVAL.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] reset: Add (devm_)reset_control_get stub functions Axel Lin <axel.lin@ingics.com> - 2015-08-31 11:30 +0200
  Re: [PATCH] reset: Add (devm_)reset_control_get stub functions Mark Brown <broonie@kernel.org> - 2015-08-31 17:00 +0200
  Re: [PATCH] reset: Add (devm_)reset_control_get stub functions Philipp Zabel <p.zabel@pengutronix.de> - 2015-08-31 18:10 +0200

csiph-web