Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1216257
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to userspace |
| Date | 2015-08-31 17:20 +0200 |
| Message-ID | <q3z2i-33U-21@gated-at.bofh.it> (permalink) |
| References | <q27hM-8oR-17@gated-at.bofh.it> <q27hM-8oR-27@gated-at.bofh.it> <q3yIX-2rV-41@gated-at.bofh.it> <q3ySC-2SC-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 31 Aug 2015 17:02:38 +0200 Vlastimil Babka <vbabka@suse.cz> wrote: > >> +#define ZONE_TYPE \ > >> + IFDEF_ZONE_DMA( EM (ZONE_DMA, "DMA")) \ > >> + IFDEF_ZONE_DMA32( EM (ZONE_DMA32, "DMA32")) \ > >> + EM (ZONE_NORMAL, "Normal") \ > >> + IFDEF_ZONE_HIGHMEM( EM (ZONE_HIGHMEM,"HighMem")) \ > >> + EMe(ZONE_MOVABLE,"Movable") > >> + > > > > Hmm, have you tried to compile this with CONFIG_ZONE_HIGHMEM disabled, > > and CONFIG_ZONE_DMA and/or CONFIG_ZONE_DMA32 enabled? > > Yep, that's standard x86_64 situation (highmem disabled, dma+dma32 enabled). > > > The EMe() macro must come last, as it doesn't have the ending comma and > > the __print_symbolic() can fail to compile due to it. > > Thanks to ZONE_MOVABLE being unconditional, EMe(ZONE_MOVABLE...) is > always last. Otherwise the macros would get even more ugly... Ah! My mistake was to see where the end parenthesis of IFDEF_ZONE_HIGHMEM() laid. It looked to me that it encompassed ZONE_MOVABLE. But obviously it does not. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/3] mm, compaction: export tracepoints zone names to userspace Vlastimil Babka <vbabka@suse.cz> - 2015-08-27 17:30 +0200
Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to userspace Steven Rostedt <rostedt@goodmis.org> - 2015-08-31 17:00 +0200
Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to userspace Vlastimil Babka <vbabka@suse.cz> - 2015-08-31 17:10 +0200
Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to userspace Steven Rostedt <rostedt@goodmis.org> - 2015-08-31 17:20 +0200
Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to userspace Steven Rostedt <rostedt@goodmis.org> - 2015-08-31 17:40 +0200
csiph-web