Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1216244

Re: [PATCH 1/3] mm, compaction: export tracepoints status strings to userspace

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] mm, compaction: export tracepoints status strings to userspace
Date 2015-08-31 17:00 +0200
Message-ID <q3yIX-2rV-43@gated-at.bofh.it> (permalink)
References <q27hM-8oR-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 27 Aug 2015 17:24:02 +0200
Vlastimil Babka <vbabka@suse.cz> wrote:

> Some compaction tracepoints convert the integer return values to strings using
> the compaction_status_string array. This works for in-kernel printing, but not
> userspace trace printing of raw captured trace such as via trace-cmd report.
> 
> This patch converts the private array to appropriate tracepoint macros that
> result in proper userspace support.
> 
> trace-cmd output before:
> transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0
>   zone=ffffffff81815d7a order=9 ret=
> 
> after:
> transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0
>   zone=ffffffff81815d7a order=9 ret=partial
> 

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: David Rientjes <rientjes@google.com>
> ---
>  include/trace/events/compaction.h | 33 +++++++++++++++++++++++++++++++--
>  mm/compaction.c                   | 11 -----------
>  2 files changed, 31 insertions(+), 13 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] mm, compaction: export tracepoints status strings to userspace Vlastimil Babka <vbabka@suse.cz> - 2015-08-27 17:30 +0200
  Re: [PATCH 1/3] mm, compaction: export tracepoints status strings  to userspace Steven Rostedt <rostedt@goodmis.org> - 2015-08-31 17:00 +0200
    Re: [PATCH 1/3] mm, compaction: export tracepoints status strings to  userspace Vlastimil Babka <vbabka@suse.cz> - 2015-08-31 17:30 +0200

csiph-web