Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216200

Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular

Show all headers | View raw

On Wed, Aug 26, 2015 at 06:11:28PM +0100, Matt Fleming wrote:
> On Tue, 25 Aug, at 07:00:48PM, Paul Gortmaker wrote:
> > The Kconfig for this driver is currently hidden with:
> > 
> > config EFI_ESRT
> >         bool
> > 
> > ...meaning that it currently is not being built as a module by anyone.
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> > 
> > Since module_init translates to device_initcall in the non-modular
> > case, the init ordering remains unchanged with this commit.
> > 
> > We leave some tags like MODULE_AUTHOR for documentation purposes.
> > 
> > We don't replace module.h with init.h since the file already has that.
> > 
> > Cc: Matt Fleming <matt.fleming@intel.com>
> > Cc: Peter Jones <pjones@redhat.com>
> > Cc: linux-efi@vger.kernel.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> Looks good to me. I know Peter is on vacation right now, so I'm still
> expecting a response from him. In the meantime, I'll queue this up in
> the EFI 'next' branch. Thanks!

Looks fine to me as well.

-- 
        Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-26 01:10 +0200
  Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly  non-modular Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-26 19:20 +0200
    Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly  non-modular Peter Jones <pjones@redhat.com> - 2015-08-31 16:00 +0200
      Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly  non-modular Matt Fleming <matt@codeblueprint.co.uk> - 2015-09-01 11:00 +0200
        Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly  non-modular Peter Jones <pjones@redhat.com> - 2015-09-01 15:20 +0200

csiph-web