Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1216160
| From | Matias Bjørling <m@bjorling.me> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] null_blk: fix wrong capacity when bs is not 512 bytes |
| Date | 2015-08-31 14:20 +0200 |
| Message-ID | <q3we5-7pO-11@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
set_capacity() sets device's capacity using 512 bytes sectors. null_blk calculates the number of sectors by size / bs, which set_capacity is called with. This led to null_blk exposing the wrong number of sectors when bs is not 512 bytes. Signed-off-by: Matias Bjørling <m@bjorling.me> --- drivers/block/null_blk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index 6f9b753..bf8f764 100644 --- a/drivers/block/null_blk.c +++ b/drivers/block/null_blk.c @@ -588,8 +588,7 @@ static int null_add_dev(void) blk_queue_physical_block_size(nullb->q, bs); size = gb * 1024 * 1024 * 1024ULL; - sector_div(size, bs); - set_capacity(disk, size); + set_capacity(disk, size >> 9); disk->flags |= GENHD_FL_EXT_DEVT | GENHD_FL_SUPPRESS_PARTITION_INFO; disk->major = null_major; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] null_blk: fix wrong capacity when bs is not 512 bytes Matias Bjørling <m@bjorling.me> - 2015-08-31 14:20 +0200 Re: [PATCH] null_blk: fix wrong capacity when bs is not 512 bytes Ross Zwisler <ross.zwisler@linux.intel.com> - 2015-09-02 20:50 +0200
csiph-web