Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216030

Re: [PATCH 1/2] x86/bitops: implement __test_bit

Show all headers | View raw

* Michael S. Tsirkin <mst@redhat.com> wrote:

> +static __always_inline int __constant_test_bit(long nr, const unsigned long *addr)
> +{
> +	return ((1UL << (nr & (BITS_PER_LONG-1))) &
> +		(addr[nr >> _BITOPS_LONG_SHIFT])) != 0;
> +}
> +
> +static inline int __variable_test_bit(long nr, const unsigned long *addr)
> +{
> +	int oldbit;
> +
> +	asm volatile("bt %2,%1\n\t"
> +		     "sbb %0,%0"
> +		     : "=r" (oldbit)
> +		     : "m" (*addr), "Ir" (nr));
> +
> +	return oldbit;
> +}

Color me confused, why use assembly for this at all?

Why not just use C for testing the bit (i.e. turn __constant_test_bit() into 
__test_bit()) - that would also allow the compiler to propagate the result, 
potentially more optimally than we can do it via SBB...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] x86/bitops: implement __test_bit "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-30 10:40 +0200
  [PATCH 2/2] kvm/x86: use __test_bit "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-30 10:40 +0200
  Re: [PATCH 1/2] x86/bitops: implement __test_bit Ingo Molnar <mingo@kernel.org> - 2015-08-31 08:10 +0200
    Re: [PATCH 1/2] x86/bitops: implement __test_bit "H. Peter Anvin" <hpa@zytor.com> - 2015-08-31 08:20 +0200
      Re: [PATCH 1/2] x86/bitops: implement __test_bit Ingo Molnar <mingo@kernel.org> - 2015-08-31 10:00 +0200
        Re: [PATCH 1/2] x86/bitops: implement __test_bit Ingo Molnar <mingo@kernel.org> - 2015-08-31 10:20 +0200
        Re: [PATCH 1/2] x86/bitops: implement __test_bit yalin wang <yalin.wang2010@gmail.com> - 2015-08-31 10:20 +0200
          Re: [PATCH 1/2] x86/bitops: implement __test_bit Ingo Molnar <mingo@kernel.org> - 2015-08-31 10:30 +0200
        Re: [PATCH 1/2] x86/bitops: implement __test_bit "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-31 13:20 +0200
          Re: [PATCH 1/2] x86/bitops: implement __test_bit Ingo Molnar <mingo@kernel.org> - 2015-09-01 11:30 +0200
            Re: [PATCH 1/2] x86/bitops: implement __test_bit "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-01 11:50 +0200
              Re: [PATCH 1/2] x86/bitops: implement __test_bit Ingo Molnar <mingo@kernel.org> - 2015-09-01 13:40 +0200
                Re: [PATCH 1/2] x86/bitops: implement __test_bit "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-01 17:10 +0200
                Re: [PATCH 1/2] x86/bitops: implement __test_bit "H. Peter Anvin" <hpa@zytor.com> - 2015-09-02 01:50 +0200
      Re: [PATCH 1/2] x86/bitops: implement __test_bit "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-31 10:00 +0200

csiph-web