Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215993

timing of module MODULE_STATE_COMING notifier

Show all headers | View raw

Hi, Rusty -

We just [1] came across your patch [2] from last year (merged into
3.17), wherein the RO/NX mapping settings for module sections were
moved to an earlier point in the module-loading sequence.

That patch also moved the MODULE_STATE_COMING notifier call to
complete_formation(), which is relatively early to its former
do_init_module() call site.  It now precedes the parse_args(),
mod_sysfs_setup(), and trace_module_load() steps.

Was the latter part of the change intended & necessary?  It is
negatively impacting systemtap, which was relying on
MODULE_STATE_COMING being called from a fairly complete module state -
just before the actual initializer function call.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=18889

[2] commit 4982223e51e8ea9d09bb33c8323b5ec1877b2b51
Author: Rusty Russell <rusty@rustcorp.com.au>
Date:   Wed May 14 10:54:19 2014 +0930


- FChE
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

timing of module MODULE_STATE_COMING notifier "Frank Ch. Eigler" <fche@redhat.com> - 2015-08-31 02:10 +0200
  Re: timing of module MODULE_STATE_COMING notifier Rusty Russell <rusty@rustcorp.com.au> - 2015-08-31 03:40 +0200
    Re: timing of module MODULE_STATE_COMING notifier "Frank Ch. Eigler" <fche@redhat.com> - 2015-08-31 15:00 +0200
      Re: timing of module MODULE_STATE_COMING notifier "Frank Ch. Eigler" <fche@redhat.com> - 2015-08-31 22:50 +0200
        Re: timing of module MODULE_STATE_COMING notifier Rusty Russell <rusty@rustcorp.com.au> - 2015-09-02 08:20 +0200

csiph-web