Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1217030

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

Show all headers | View raw

Hi!

> -EXPORT_SYMBOL_GPL(of_cpumask_init_opp_table);
> +EXPORT_SYMBOL_GPL(dev_pm_opp_cpumask_init_opp);

Well... it starts to be rather long and repetitive.

> @@ -237,7 +237,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
>  	 *
>  	 * OPPs might be populated at runtime, don't check for error here
>  	 */
> -	of_cpumask_init_opp_table(policy->cpus);
> +	dev_pm_opp_cpumask_init_opp(policy->cpus);
>  
>  	if (need_update) {
>  		struct cpufreq_dt_platform_data *pd = cpufreq_get_driver_data();
...
> @@ -356,7 +356,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
>  out_free_priv:
>  	kfree(priv);
>  out_free_opp:
> -	of_cpumask_free_opp_table(policy->cpus);
> +	dev_pm_opp_cpumask_free_table(policy->cpus);
>  out_node_put:
>  	of_node_put(np);
>  out_put_reg_clk:

Is ..._free_table opposite of ..._init_opp? If so, you might want to
name them such that it is clear...

Thanks,
										Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_ Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-01 07:00 +0200
  Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines  with dev_pm_opp_ Pavel Machek <pavel@ucw.cz> - 2015-09-01 21:10 +0200
    Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines  with dev_pm_opp_ Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-02 09:30 +0200
      Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines  with dev_pm_opp_ Stephen Boyd <sboyd@codeaurora.org> - 2015-09-03 02:10 +0200
    Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines  with dev_pm_opp_ Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-02 09:30 +0200

csiph-web