Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1216938
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] arm: omap2: vc: fix 'or' always true warning |
| Date | 2015-09-01 17:50 +0200 |
| Message-ID | <q3VYT-2pS-23@gated-at.bofh.it> (permalink) |
| References | <q2p50-t4-5@gated-at.bofh.it> <q2p50-t4-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Frans Klaver <frans.klaver@xsens.com> [150828 03:14]:
> From: Frans Klaver <fransklaver@gmail.com>
>
> Fix the warning:
> arch/arm/mach-omap2/vc.c:302:47: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
>
> As we're toggling both CLKREQ and OFFMODE, we should also be checking
> OFFMODE.
>
> Signed-off-by: Frans Klaver <fransklaver@gmail.com>
Thanks apppying into omap-for-v4.3/fixes.
Tony
> ---
> arch/arm/mach-omap2/vc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index 076fd20d7e5a..807bc79e3e3d 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -300,7 +300,7 @@ static void __init omap3_vc_init_pmic_signaling(struct voltagedomain *voltdm)
>
> val = voltdm->read(OMAP3_PRM_POLCTRL_OFFSET);
> if (!(val & OMAP3430_PRM_POLCTRL_CLKREQ_POL) ||
> - (val & OMAP3430_PRM_POLCTRL_CLKREQ_POL)) {
> + (val & OMAP3430_PRM_POLCTRL_OFFMODE_POL)) {
> val |= OMAP3430_PRM_POLCTRL_CLKREQ_POL;
> val &= ~OMAP3430_PRM_POLCTRL_OFFMODE_POL;
> pr_debug("PM: fixing sys_clkreq and sys_off_mode polarity to 0x%x\n",
> --
> 2.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] arm: omap2: vc: fix 'or' always true warning Frans Klaver <frans.klaver@xsens.com> - 2015-08-28 12:30 +0200
Re: [PATCH] arm: omap2: vc: fix 'or' always true warning Tony Lindgren <tony@atomide.com> - 2015-09-01 17:50 +0200
Re: [PATCH] arm: omap2: vc: fix 'or' always true warning Frans Klaver <fransklaver@gmail.com> - 2015-09-01 20:30 +0200
csiph-web