Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216784

Re: [PATCH v2][RESEND] perf, x86: Fix multi-segment problem of perf_event_intel_uncore

Show all headers | View raw

On Tue, Sep 01, 2015 at 01:31:47PM +0200, Ingo Molnar wrote:
> 
> * Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > +struct __find_pci2phy(int segment)
> > +{
> > +	struct pci2phy_map *map;
> > +
> > +	lockdep_assert_held(&pci2phy_map_lock);
> > +
> > +	list_for_each_entry(map, &pci2phy_map_head, list) {
> > +		if (map->segment == segment)
> > +			return map;
> > +	}
> > +
> > +	map = kmalloc(sizeof(struct pci2phy_map), GFP_ATOMIC);
> 
> I really don't think we should be adding new GFP_ATOMIC allocations whenever it 
> can be avoided.

I tend to agree, it makes the whole thing rather fragile...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2][RESEND] perf, x86: Fix multi-segment problem of perf_event_intel_uncore Taku Izumi <izumi.taku@jp.fujitsu.com> - 2015-08-27 04:00 +0200
  Re: [PATCH v2][RESEND] perf, x86: Fix multi-segment problem of  perf_event_intel_uncore Peter Zijlstra <peterz@infradead.org> - 2015-09-01 13:20 +0200
    Re: [PATCH v2][RESEND] perf, x86: Fix multi-segment problem of  perf_event_intel_uncore Ingo Molnar <mingo@kernel.org> - 2015-09-01 13:40 +0200
      Re: [PATCH v2][RESEND] perf, x86: Fix multi-segment problem of  perf_event_intel_uncore Peter Zijlstra <peterz@infradead.org> - 2015-09-01 13:40 +0200

csiph-web