Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216750

[PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

On the unlikely event that drv is null, the current code will
perform a null pointer dereference with it when printing a dev_dbg
message.  Instead, the BUG_ON check on drv should be performed
before we emit the dev_dbg message.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/ps3/ps3-vuart.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c
index d6db822..632701a 100644
--- a/drivers/ps3/ps3-vuart.c
+++ b/drivers/ps3/ps3-vuart.c
@@ -1000,12 +1000,11 @@ static int ps3_vuart_probe(struct ps3_system_bus_device *dev)
 	dev_dbg(&dev->core, "%s:%d\n", __func__, __LINE__);
 
 	drv = ps3_system_bus_dev_to_vuart_drv(dev);
+	BUG_ON(!drv);
 
 	dev_dbg(&dev->core, "%s:%d: (%s)\n", __func__, __LINE__,
 		drv->core.core.name);
 
-	BUG_ON(!drv);
-
 	if (dev->port_number >= PORT_COUNT) {
 		BUG();
 		return -EINVAL;
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg Colin King <colin.king@canonical.com> - 2015-09-01 12:30 +0200
  Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-01 12:40 +0200
    Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it  on dev_dbg Colin Ian King <colin.king@canonical.com> - 2015-09-01 12:40 +0200
      Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-01 13:30 +0200
  Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it  on dev_dbg Geoff Levand <geoff@infradead.org> - 2015-09-01 19:30 +0200

csiph-web