Re: [PATCH] efifb: Add support for 64-bit frame buffer addresses

From	Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] efifb: Add support for 64-bit frame buffer addresses
Date	2015-09-01 11:00 +0200
Message-ID	<q3PA5-1Ef-1@gated-at.bofh.it> (permalink)
References	<q2qNs-2Z9-5@gated-at.bofh.it> <q3DSi-1zN-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 31 Aug, at 10:24:31PM, Geert Uytterhoeven wrote:
> On Fri, Aug 28, 2015 at 2:12 PM, Matt Fleming <matt@codeblueprint.co.uk> wrote:
> > --- a/arch/x86/boot/compressed/eboot.c
> > +++ b/arch/x86/boot/compressed/eboot.c
> > @@ -624,7 +624,7 @@ setup_pixel_info(struct screen_info *si, u32 pixels_per_scan_line,
> >  static efi_status_t
> >  __gop_query32(struct efi_graphics_output_protocol_32 *gop32,
> >               struct efi_graphics_output_mode_info **info,
> > -             unsigned long *size, u32 *fb_base)
> > +             unsigned long *size, u64 *fb_base)
> 
> phys_addr_t instead of u64?

I can see why you might think that, but no, phys_addr_t isn't the
correct data type because your kernel config dictates whether that's
u32 or u64.

We're interacting with the firmware here and the frame buffer address
is always u64, for both 32-bit and 64-bit firmware. It's defined that
way in the UEFI spec.

It's better to be explicit about these kinds of things, and use u64.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] efifb: Add support for 64-bit frame buffer addresses Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-28 14:20 +0200
  Re: [PATCH] efifb: Add support for 64-bit frame buffer addresses Peter Jones <pjones@redhat.com> - 2015-08-31 17:30 +0200
  Re: [PATCH] efifb: Add support for 64-bit frame buffer addresses Geert Uytterhoeven <geert@linux-m68k.org> - 2015-08-31 22:30 +0200
    Re: [PATCH] efifb: Add support for 64-bit frame buffer addresses Matt Fleming <matt@codeblueprint.co.uk> - 2015-09-01 11:00 +0200

csiph-web