Re: [PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by PT decoders

From	Andi Kleen <andi@firstfloor.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by PT decoders
Date	2015-08-31 22:10 +0200
Message-ID	<q3DyX-1dj-31@gated-at.bofh.it> (permalink)
References	<q26Yq-828-17@gated-at.bofh.it> <q2xFg-4lL-13@gated-at.bofh.it> <q3wQO-89h-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 31, 2015 at 03:59:08PM +0300, Alexander Shishkin wrote:
> Andi Kleen <andi@firstfloor.org> writes:
> 
> > Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
> >> +		return sprintf(page, "%lu\n", val);
> >> +	case 1:
> >> +		cpuid(0x15, &eax, &ebx, &ecx, &edx);
> >
> > Surely this needs to be protected by a cpuid level check?
> > Broadwell for once doesn't have CPUID 0x15.
> 
> I couldn't find where this is explicitly said in the SDM. However, the
> leaf description says that CPUID.0x15.EBX[31:0]==0 means that the ratio
> is not enumerated. I don't see how to better communicate this to
> userspace though than to simply have 0 there.

What I meant is -- the kernel may crash on a older CPU that does
not support CPUID 0x15. For example Broadwell doesn't have it.
For CPUID you always need to check the level.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by PT decoders Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-08-27 17:10 +0200
  Re: [PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by PT decoders Andi Kleen <andi@firstfloor.org> - 2015-08-28 21:40 +0200
    Re: [PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by PT decoders Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-08-31 15:00 +0200
      Re: [PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by  PT decoders Andi Kleen <andi@firstfloor.org> - 2015-08-31 22:10 +0200

csiph-web